[PATCH] D18722: [tsan] Add interceptors for dispatch_apply

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 2 10:21:11 PDT 2016


kubabrecka added inline comments.

================
Comment at: lib/tsan/rtl/tsan_libdispatch_mac.cc:300
@@ +299,3 @@
+  };
+  SCOPED_TSAN_INTERCEPTOR_USER_CALLBACK_START();
+  REAL(dispatch_apply)(iterations, queue, new_block);
----------------
dvyukov wrote:
> Why do we need this around REAL(dispatch_apply)?
dispatch_apply can use the current thread (if it's part of `queue`) and call the callback on it.


http://reviews.llvm.org/D18722





More information about the llvm-commits mailing list