[PATCH] D18346: ThinLTO: special handling for LinkOnce functions

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 12:38:04 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:190
@@ +189,3 @@
+  for (auto &GV : TheModule.globals()) {
+    if (!GlobalInvolvedWithAlias.count(&GV))
+      ResolveODR(GV, Index, TheModule.getModuleIdentifier());
----------------
Yeah, but I'd prefer to have the "real" solution we discussed instead of an intermediate one, keeping a  limited/conservative behavior in presence of aliases for now.


http://reviews.llvm.org/D18346





More information about the llvm-commits mailing list