[PATCH] D18699: [ELF] - Teach linkerscript error handler to show full script line + column marker on error.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 12:15:26 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:176
@@ -174,1 +175,3 @@
 
+std::pair<StringRef, size_t> ScriptParser::getLineColumn() {
+  const char *Begin = Input.data();
----------------
ruiu wrote:
> The string manipulation in this function seem a bit too complicated. StringRef provides a good set of utility functions to make this kind of stuff easy. Can you rewrite it with them?
Done.


http://reviews.llvm.org/D18699





More information about the llvm-commits mailing list