[PATCH] D18593: [PowerPC] Front end improvements for vec_splat

[amehsan via llvm-commits]

amehsan added a comment.

FWIW LGTM ;-)

One question: xxspltd is an extended mnemonic for xxpermdi. In your current patch for BE I do not see adding a pattern for xxpermdi. Did you add some code to that patch that is not yet posted here? Or something else is going on here?

I have added a minor nit as well.


================
Comment at: test/CodeGen/ppc-vsx-splat.c:66
@@ +65,3 @@
+
+vector signed long long spltd0(vector signed long long a, unsigned b) {
+  return vec_splat(a, 0);
----------------
b is unused

================
Comment at: test/CodeGen/ppc-vsx-splat.c:74
@@ +73,3 @@
+
+vector signed long long spltd1(vector signed long long a, unsigned b) {
+  return vec_splat(a, 1);
----------------
same here


Repository:
  rL LLVM

http://reviews.llvm.org/D18593