[PATCH] D18681: [PGO] Avoid instrumenting direct callee's at value sites.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 08:54:29 PDT 2016


vsk added a subscriber: vsk.
vsk added a comment.

Thanks, could you add a test in test/Transforms/PGOProfile/do-not-instrument.ll?


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:336
@@ -335,3 +335,3 @@
   void visitCallSite(CallSite CS) {
     if (CS.getCalledFunction() || !CS.getCalledValue())
       return;
----------------
Wdyt of `... || !dyn_cast_or_null<Constant>(CS.getCalledValue())`? I prefer it slightly, but your patch is good as-is.


Repository:
  rL LLVM

http://reviews.llvm.org/D18681





More information about the llvm-commits mailing list