[PATCH] D18676: [x86] avoid intermediate splat for non-zero memsets (PR27100)

[Simon Pilgrim via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - one comment


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2035
@@ +2034,3 @@
+      if (Size >= 32 && Subtarget.hasAVX()) {
+        // Although this isn't a legal type for AVX1, we'll let legalization
+        // and shuffle lowering produce the optimal codegen. If we choose
----------------
This /is/ a legal type for AVX1 - the trouble is we can't do much with it.


http://reviews.llvm.org/D18676