[PATCH] D17872: [NVPTX] Add a truncate DAG node to some calls.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 15:41:55 PDT 2016


jlebar added a comment.

In http://reviews.llvm.org/D17872#388029, @jholewinski wrote:

> That's for... hmm... I don't know.  I don't see how that block would be executed. The call lowering code has always been a mess, unfortunately.


Hey, a real, live Chesterton's Fence!

In the interest of not changing things that I don't understand, I think I'll leave out the needTruncate on this path, and add a comment saying we may need it, if we can figure out what the branch is for at all.


http://reviews.llvm.org/D17872





More information about the llvm-commits mailing list