[PATCH] D18658: [AsmPrinter] Print aliases in topological order

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 14:51:43 PDT 2016


echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.

This seems to be as good as anywhere else to do this.

It's also crazy, but well spotted. One inline nit.

-eric


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1199
@@ +1198,3 @@
+         Cur = dyn_cast<GlobalAlias>(Cur->getAliasee())) {
+      if (AliasVisited.insert(Cur).second) {
+        AliasStack.push_back(Cur);
----------------
Nit: No braces around single conditionals.


http://reviews.llvm.org/D18658





More information about the llvm-commits mailing list