[PATCH] D15525: [GCC] Attribute ifunc support in llvm

[Eric Christopher via llvm-commits]

echristo added a comment.

Highlighted a couple of things that could be pulled out into an incremental patch (and you can pull out similar Alias->IndirectSymbol changes).

Thanks!

-eric


================
Comment at: include/llvm/CodeGen/AsmPrinter.h:550-552
@@ -548,2 +549,5 @@
   GCMetadataPrinter *GetOrCreateGCPrinter(GCStrategy &C);
+  /// Emit GlobalAlias or GlobalIFunc.
+  void emitGlobalIndirectSymbol(Module &M,
+                                const GlobalIndirectSymbol& GIS);
 };
----------------
This isn't part of the previous patch? 

================
Comment at: lib/AsmParser/LLParser.h:278-282
@@ -277,5 +277,7 @@
                      GlobalVariable::ThreadLocalMode TLM, bool UnnamedAddr);
-    bool ParseAlias(const std::string &Name, LocTy Loc, unsigned Linkage,
-                    unsigned Visibility, unsigned DLLStorageClass,
-                    GlobalVariable::ThreadLocalMode TLM, bool UnnamedAddr);
+    bool parseIndirectSymbol(const std::string &Name, LocTy Loc,
+                             unsigned Linkage, unsigned Visibility,
+                             unsigned DLLStorageClass,
+                             GlobalVariable::ThreadLocalMode TLM,
+                             bool UnnamedAddr);
     bool parseComdat();
----------------
Ditto.


http://reviews.llvm.org/D15525