[PATCH] D18467: Add disk_space() to llvm::fs

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 13:57:18 PDT 2016


ruiu added a subscriber: ruiu.

================
Comment at: include/llvm/Support/FileSystem.h:655
@@ +654,3 @@
+/// Note: Users must be careful about "Time Of Check, Time Of Use" kind of bug.
+/// Note: Windows reports results according to the quota allocated to the user.
+///
----------------
"reports reports"

================
Comment at: include/llvm/Support/FileSystem.h:662
@@ +661,3 @@
+///          platform specific error_code.
+ErrorOr<space_info> disk_space(const Twine Path);
+
----------------
const Twine Path -> const Twine &Path?


http://reviews.llvm.org/D18467





More information about the llvm-commits mailing list