[PATCH] D17934: [ELF] Implement infrastructure for thunk code creation

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 09:24:24 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. I think it is now simple enough to submit. Thanks!


================
Comment at: ELF/Writer.cpp:316
@@ +315,3 @@
+
+    if (!Body.hasThunk() && Target->needsThunk(Type, File, Body)) {
+      auto *D = cast<DefinedRegular<ELFT>>(&Body);
----------------
Invert the condition and use `continue`.


Repository:
  rL LLVM

http://reviews.llvm.org/D17934





More information about the llvm-commits mailing list