[PATCH] D18570: [AArch64] Handle missing store pair opportunity

[Junmo Park via llvm-commits]

flyingforyou added a subscriber: flyingforyou.
flyingforyou added a comment.

LGTM, too. with a few minor nits.


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1608
@@ -1607,3 +1607,3 @@
   MachineBasicBlock::iterator MergeMI =
-      findMatchingInsn(MBBI, Flags, LdStLimit);
+      findMatchingInsn(MBBI, Flags, LdStLimit, /*FindNarrowMerge=*/true);
   if (MergeMI != E) {
----------------
Please put a space.

`"/*FindNarrowMerge = */ true"`

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1644
@@ -1644,1 +1643,3 @@
+  MachineBasicBlock::iterator Paired =
+      findMatchingInsn(MBBI, Flags, LdStLimit, /*FindNarrowMerge=*/false);
   if (Paired != E) {
----------------
Please put a space `/*FindNarrowMerge = */ false`.


http://reviews.llvm.org/D18570