[lld] r264945 - Remove useless unreachable. Switch coverage already gives us this. NFC

[Mehdi Amini via llvm-commits]

> On Mar 30, 2016, at 3:34 PM, Pete Cooper via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: pete
> Date: Wed Mar 30 17:34:37 2016
> New Revision: 264945
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=264945&view=rev
> Log:
> Remove useless unreachable.  Switch coverage already gives us this.  NFC

Does the optimizer has a notion of the switch coverage here? Or is the front-end generating an unreachable after your change? 

Also it is not totally NFC as llvm_unreachable is lowered to a real check in an assert build.

-- 
Mehdi



> 
> Modified:
>    lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp
> 
> Modified: lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp?rev=264945&r1=264944&r2=264945&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp (original)
> +++ lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp Wed Mar 30 17:34:37 2016
> @@ -865,7 +865,6 @@ std::error_code Util::getSymbolTableRegi
>     }
>     break;
>   }
> -  llvm_unreachable("atom->scope() unknown enum value");
> }
> 
> std::error_code Util::addSymbols(const lld::File &atomFile,
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits