[PATCH] D18573: [X86] Enable call frame optimization ("mov to push") not only for optsize (PR26325)

[Hans Wennborg via llvm-commits]

hans added inline comments.

================
Comment at: test/CodeGen/X86/win32-seh-nested-finally.ll:46
@@ -45,3 +45,3 @@
 ; CHECK: movl $1, -[[state]](%ebp)
-; CHECK: movl $1, (%esp)
+; CHECK: pushl $1
 ; CHECK: calll _f
----------------
hans wrote:
> joerg wrote:
> > The changes here look suspicious, doesn't the code need to restore %esp before the final popl?
> This does look weird. Reid, is there something magic about these invokes, or is mov-to-push broken here?
Oh wait, %esp does get restored in between, it's just not in the test expectations. Let me fix that..


http://reviews.llvm.org/D18573