[PATCH] D18578: BitVector: Add insert() and erase() methods.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 14:00:47 PDT 2016


MatzeB added a comment.

In http://reviews.llvm.org/D18578#386549, @dblaikie wrote:

> Test cases?
>  Got a usage in mind?


The concrete usage I have in mind is using a BitVector for Set type parameter of a SetVector. This is in the context of http://reviews.llvm.org/D18427.

And if you think about it: Even though the class is called a BitVector most of the time you really use it more like a set where you insert and remove elements from and not like a vector there is no BitVector::push_back() or iterators after all. So having operations compatible with std::set and DenseSet makes sense.


Repository:
  rL LLVM

http://reviews.llvm.org/D18578





More information about the llvm-commits mailing list