[PATCH] D18615: [NVPTX] Make NVVMReflect a function pass.

[Artem Belevich via llvm-commits]

tra added a comment.

Two nits. Looks good otherwise.


================
Comment at: lib/Target/NVPTX/NVVMReflect.cpp:132
@@ -141,2 +131,3 @@
 
-  // IR for __nvvm_reflect calls differs between CUDA versions:
+  // Go through the calls in this instruction.  Each call to __nvvm_reflect or
+  // llvm.nvvm.reflect should be a CallInst with a ConstantArray argument.
----------------
Did you mean "calls in this function" ?

================
Comment at: lib/Target/NVPTX/NVVMReflect.cpp:174
@@ -170,3 +173,3 @@
+    const Value *Str = Call->getArgOperand(0);
     if (isa<CallInst>(Str)) {
       const CallInst *ConvCall = cast<CallInst>(Str);
----------------
if (const CallInst *ConvCall = dyn_cast<CallInst>(Str))



http://reviews.llvm.org/D18615