[PATCH] D18213: Add a module Hash in the bitcode and the combined index.

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D18213#386848, @joker.eph wrote:

> The test are checking for "match" in the output of llvm-bcanalyzer


Which test? Is there a new test missing from the patch? The hash generation is off by default so I assume you need to add a new one (or modify an existing) to pass the new -module-hash option to llvm-as. Otherwise I don't think the checking in llvm-bcanalyzer will ever kick in.


================
Comment at: tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp:599
@@ +598,3 @@
+      // If we found a module hash, let's verify that it matches!
+      if (BlockID == bitc::MODULE_BLOCK_ID && Code == bitc::MODULE_CODE_HASH) {
+        if (Record.size() != 5)
----------------
Is the MODULE_CODE_HASH ever expected outside a module block? If not, can the first part of the if be turned into an assert inside the if body?


http://reviews.llvm.org/D18213