[PATCH] D18589: Fix camelCase / non-camelCase typo in dllexport test

Warren Ristow via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 23:30:01 PDT 2016


wristow created this revision.
wristow added reviewers: rnk, silvas.
wristow added a subscriber: llvm-commits.

The test case was defining and using a function 'notExported()', but
the FileCheck checks were checking for the name 'not_exported'.  This
changes the test to use 'notExported' across the board.  Also, the test
defined a function 'not_defined()', but doesn't have any checks related
to it.  For consistency, this name is changed to 'notDefined'.  A later
commit will add checks for 'notDefined'.

http://reviews.llvm.org/D18589

Files:
  llvm/test/CodeGen/X86/dllexport.ll

Index: llvm/test/CodeGen/X86/dllexport.ll
===================================================================
--- llvm/test/CodeGen/X86/dllexport.ll
+++ llvm/test/CodeGen/X86/dllexport.ll
@@ -21,7 +21,7 @@
 	ret void
 }
 
-declare dllexport void @not_defined()
+declare dllexport void @notDefined()
 
 ; CHECK: .globl _stdfun at 0
 define dllexport x86_stdcallcc void @stdfun() nounwind {
@@ -89,7 +89,7 @@
 @weak_alias = weak_odr dllexport alias void(), void()* @f1
 
 ; CHECK: .section .drectve
-; CHECK-CL-NOT: not_exported
+; CHECK-CL-NOT: notExported
 ; CHECK-CL: /EXPORT:_f1
 ; CHECK-CL-SAME: /EXPORT:_f2
 ; CHECK-CL-SAME: /EXPORT:_stdfun at 0
@@ -107,8 +107,8 @@
 ; CHECK-CL-SAME: /EXPORT:_alias2
 ; CHECK-CL-SAME: /EXPORT:_alias3
 ; CHECK-CL-SAME: /EXPORT:_weak_alias"
-; CHECK-CL-NOT: not_exported
-; CHECK-GCC-NOT: not_exported
+; CHECK-CL-NOT: notExported
+; CHECK-GCC-NOT: notExported
 ; CHECK-GCC: -export:f1
 ; CHECK-GCC-SAME: -export:f2
 ; CHECK-GCC-SAME: -export:stdfun at 0
@@ -126,4 +126,4 @@
 ; CHECK-GCC-SAME: -export:alias2
 ; CHECK-GCC-SAME: -export:alias3
 ; CHECK-GCC-SAME: -export:weak_alias"
-; CHECK-GCC-NOT: not_exported
+; CHECK-GCC-NOT: notExported


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18589.52022.patch
Type: text/x-patch
Size: 1170 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160330/f3ae6db7/attachment.bin>


More information about the llvm-commits mailing list