[PATCH] D18506: Add a copy constructor to StringMap

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 21:01:06 PDT 2016


joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

Thanks for all the answers. LGTM then.


================
Comment at: include/llvm/ADT/StringMap.h:94
@@ -93,2 +93,3 @@
+  /// setup the map as empty.
   void init(unsigned Size);
 
----------------
hfinkel wrote:
> joker.eph wrote:
> > private -> public is a bit rough, could it be protected maybe?
> Yes, it is (all of the functions in this block are protected).
OK nevermind then...


http://reviews.llvm.org/D18506





More information about the llvm-commits mailing list