[PATCH] D18581: Simplify AHL handling

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 15:36:47 PDT 2016


rafael created this revision.
rafael added a reviewer: atanasyan.
rafael added a subscriber: llvm-commits.

This simplifies a few things

* Read the value as early as possible, instead of passing a pointer to the location.
* Print the warning for missing pair close to where we find out it is missing.

This is not a complete nop for the case where there is no matching relocation. We now read the high part of the addend. Note that we were already doing that when creating a got entry, but not when computing relocations.

According to the spec (4-17 at ftp://www.linux-mips.org/pub/linux/mips/doc/ABI/mipsabi.pdf) each high relocation *must* have a matching lo, so this is hopefully OK.


http://reviews.llvm.org/D18581

Files:
  ELF/InputSection.cpp
  ELF/InputSection.h
  ELF/Target.cpp
  ELF/Target.h
  test/ELF/mips-hilo-hi-only.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18581.51992.patch
Type: text/x-patch
Size: 13240 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160329/9d4bb502/attachment.bin>


More information about the llvm-commits mailing list