[PATCH] D18546: Prevent X86IselLowering from merging volatile loads

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 14:12:44 PDT 2016


RKSimon added a comment.

I'm not sure if this is necessary - we already check that we're not merging consecutive loads where any/all the loads are volatiles. DAG.isConsecutiveLoad handles these cases for us (and its why we already have tests for them) - we shouldn't need to check again in EltsFromConsecutiveLoads.

If you wish to add additional volatile load tests that'd be great; but please note, we auto-generate the merge-consecutive-loads-*.ll test files (something we're trying to encourage) - manually editting these files with entwined DAG checks is not easy to maintain.


http://reviews.llvm.org/D18546





More information about the llvm-commits mailing list