[PATCH] D12191: AAP Backend

[Chris Bieneman via llvm-commits]

beanz added a subscriber: beanz.
beanz added a comment.

I'm not qualified to comment on the backend itself, but a few notes on the build system changes.

First and foremost, please don't add Makefiles to LLVM. I spent a lot of time getting rid of them, and we no longer support autoconf.

I additionally have one small CMake comment inline.

-Chris


================
Comment at: CMakeLists.txt:210
@@ -209,2 +209,3 @@
 set(LLVM_ALL_TARGETS
+  AAP
   AArch64
----------------
New backends should't be added to the default backend list. They should be added as experimental only.

Experimental backends are not specified in the CMake explicitly, you enable them by specifying them on the CMake command line with the variable LLVM_EXPERIMENTAL_TARGETS_TO_BUILD.


http://reviews.llvm.org/D12191