[PATCH] D18092: Swift Calling Convention: add swifterror attribute

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 10:44:31 PDT 2016


joker.eph added inline comments.

================
Comment at: include/llvm/Target/TargetCallingConv.h:92
@@ +91,3 @@
+    bool isSwiftError() const { return Flags & SwiftError; }
+    void setSwiftError() { Flags = One << SwiftErrorOffs; }
+
----------------
`Flags |= ...`

================
Comment at: test/Bitcode/swifterror.ll:8
@@ +7,2 @@
+  ret i32 0
+}
----------------
I think we could have a test for the alloca at the call site, and a function that takes a SwiftError in another position than the first parameter.


http://reviews.llvm.org/D18092





More information about the llvm-commits mailing list