[PATCH] D18528: Don't fold double constant to an integer if dest type not integral

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 09:37:25 PDT 2016


ab added a subscriber: ab.
ab added a comment.

x86_mmx strikes again!

LGTM, but the test shouldn't be in CodeGen. It's not great either, but what about Transforms/EarlyCSE?


================
Comment at: test/CodeGen/X86/mmx-bitcast-fold.ll:1
@@ +1,2 @@
+; RUN: opt -mtriple=x86_64-linux-gnu -early-cse < %s -S | FileCheck %s
+
----------------
Perhaps x86_64-- ?

================
Comment at: test/CodeGen/X86/mmx-bitcast-fold.ll:5
@@ +4,3 @@
+
+define internal void @bar() {
+entry:
----------------
-internal

================
Comment at: test/CodeGen/X86/mmx-bitcast-fold.ll:8
@@ +7,3 @@
+  %0 = bitcast double 0.0 to x86_mmx
+  %1 = tail call x86_mmx @foo(x86_mmx %0)
+  ret void
----------------
-tail


http://reviews.llvm.org/D18528





More information about the llvm-commits mailing list