[PATCH] D18407: Add -fno-jump-tables and-fjump-tables flags

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 08:04:29 PDT 2016


niravd added inline comments.

================
Comment at: include/clang/Driver/Options.td:590
@@ +589,3 @@
+def fjump_tables : Flag<["-"], "fjump-tables">, Group<f_Group>,
+  HelpText<"Use jump tables for sufficiently large switch">;
+def fno_jump_tables : Flag<["-"], "fno-jump-tables">, Group<f_Group>, Flags<[CC1Option]>;
----------------
hans wrote:
> It's not just the size of the switch, but also the density, etc.
> 
> I think it would make more sense to add HelpText to the -fno flag below instead. How about:
> 
> "Do not use jump tables for lowering switches"
This is help message for from GCC, but I agree this is clearer


http://reviews.llvm.org/D18407





More information about the llvm-commits mailing list