[LNT] r264725 - [search] Add documentation and remove unused default_order parameter.

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 05:11:41 PDT 2016


Author: jamesm
Date: Tue Mar 29 07:11:41 2016
New Revision: 264725

URL: http://llvm.org/viewvc/llvm-project?rev=264725&view=rev
Log:
[search] Add documentation and remove unused default_order parameter.

Modified:
    lnt/trunk/lnt/server/db/search.py

Modified: lnt/trunk/lnt/server/db/search.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/search.py?rev=264725&r1=264724&r2=264725&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/search.py (original)
+++ lnt/trunk/lnt/server/db/search.py Tue Mar 29 07:11:41 2016
@@ -1,6 +1,6 @@
 import re
 
-def _naive_search_for_run(ts, query, num_results, default_machine, default_order):
+def _naive_search_for_run(ts, query, num_results, default_machine):
     """
     This 'naive' search doesn't rely on any indexes so can be used without
     full-text search enabled. This does make it less clever however.
@@ -32,9 +32,6 @@ def _naive_search_for_run(ts, query, num
         # doing a full table scan and that is not scalable.
         return []
 
-    if default_order:
-        order_queries.append(default_order)
-
     machines = []
     if not machine_queries:
         machines = [default_machine]
@@ -62,9 +59,18 @@ def _naive_search_for_run(ts, query, num
         
         
 def search(ts, query,
-           num_results=8, default_machine=None, default_order=None):
+           num_results=8, default_machine=None):
     """
+    Performs a textual search for a run. The exact syntax supported depends on the engine
+    used to perform the search; see _naive_search_for_run for the minimum supported syntax.
+
+    ts: TestSuite object
+    query: Textual query string
+    num_results: Number of results to return
+    default_machine: If no machines were specified (only orders), return results from this machine.
+
+    Returns a list of Run objects.
     """
 
     return _naive_search_for_run(ts, query,
-                                 num_results, default_machine, default_order)
+                                 num_results, default_machine)




More information about the llvm-commits mailing list