[llvm] r264699 - BitcodeReader: Allow METADATA_STRINGS to only have !""

[Duncan P. N. Exon Smith via llvm-commits]

Author: dexonsmith
Date: Tue Mar 29 00:25:17 2016
New Revision: 264699

URL: http://llvm.org/viewvc/llvm-project?rev=264699&view=rev
Log:
BitcodeReader: Allow METADATA_STRINGS to only have !""

Support parsing a METADATA_STRINGS record that only has a single piece
of metadata, !"".  Fixes a corner case in r264551.

Added:
    llvm/trunk/test/Bitcode/metadata-only-empty-string.ll
Modified:
    llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp

Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=264699&r1=264698&r2=264699&view=diff
==============================================================================
--- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)
+++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Tue Mar 29 00:25:17 2016
@@ -1899,7 +1899,7 @@ std::error_code BitcodeReader::parseMeta
   unsigned StringsOffset = Record[1];
   if (!NumStrings)
     return error("Invalid record: metadata strings with no strings");
-  if (StringsOffset >= Blob.size())
+  if (StringsOffset > Blob.size())
     return error("Invalid record: metadata strings corrupt offset");
 
   StringRef Lengths = Blob.slice(0, StringsOffset);

Added: llvm/trunk/test/Bitcode/metadata-only-empty-string.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/metadata-only-empty-string.ll?rev=264699&view=auto
==============================================================================
--- llvm/trunk/test/Bitcode/metadata-only-empty-string.ll (added)
+++ llvm/trunk/test/Bitcode/metadata-only-empty-string.ll Tue Mar 29 00:25:17 2016
@@ -0,0 +1,7 @@
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
+
+; CHECK: !named = !{!0}
+!named = !{!0}
+
+; CHECK: !0 = !{!""}
+!0 = !{!""}