[PATCH] D18357: [LTO] Include in .symtab/.dynsym symbols introduced by optimizations

[Rafael Espíndola via llvm-commits]

On Mar 28, 2016 8:22 PM, "Rui Ueyama" <ruiu at google.com> wrote:
>
> On Mon, Mar 28, 2016 at 3:24 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
>>
>> On 28 March 2016 at 14:59, Rui Ueyama <ruiu at google.com> wrote:
>> > ruiu added a subscriber: ruiu.
>> > ruiu added a comment.
>> >
>> > Maybe we should rename IsUsedInRegularObj -> MustBeInSymtab?
>>
>> That seems a bit more confusion IMHO.
>
>
> But that is the behavior if this bit is on, no? What is confusing is
probably the lack of comment of IsUsedInRegularObj function.

It implicates that a symbol has to be in the symbol table, yes.

The reason I would find MustBeInSymtab confusing is that I would read it as
an "if and only if".

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160328/dd93cc9e/attachment.html>