[PATCH] D18357: [LTO] Include in .symtab/.dynsym symbols introduced by optimizations

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: ELF/SymbolTable.cpp:112
@@ -112,1 +111,3 @@
+   if (!Sym->Body->isUndefined() && Body->isUndefined()) {
+      Sym->Body->setUsedInRegularObj();
       continue;
----------------
You can just unconditionally set this, no?
That would be simpler and a bit more like what happens during regular symbol resolution.

================
Comment at: test/ELF/lto/undefined-puts.ll:20
@@ +19,3 @@
+
+; Check that puts symbol is present in the dynamic symbol table.
+; CHECK: DynamicSymbols [
----------------
It is also used in a relocation, no? Can you check that for completeness?


http://reviews.llvm.org/D18357