[PATCH] D17736: [SSP] Remove llvm.stackprotectorcheck.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 14:42:44 PDT 2016


timshen added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2179
@@ +2178,3 @@
+  unsigned Offset = (Subtarget.is64Bit()) ? 0x28 : 0x14;
+  unsigned AddressSpace = getAddressSpace();
+  PointerType *PtrTy = Type::getInt8PtrTy(M.getContext());
----------------
iteratee wrote:
> The address space will go away in a later patch, correct?
Yes, finally X86 should use LOAD_STACK_GUARD as well, but before that I'd like to introduce llvm.stackguard() intrinsic. After that point getStackGuardAddr isn't even needed.


http://reviews.llvm.org/D17736





More information about the llvm-commits mailing list