[compiler-rt] r264612 - [PGO] Comment how function pointers for indirect calls are mapped to function names

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 11:53:25 PDT 2016


r264615

> On Mar 28, 2016, at 11:38 AM, Xinliang David Li <xinliangli at gmail.com> wrote:
> 
> That is right.  Thanks for catching this.
> 
> David
> 
> On Mon, Mar 28, 2016 at 11:36 AM, Sean Silva via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> I think this file has to use C-style /* */ comments.
> 
> On Mon, Mar 28, 2016 at 11:29 AM, Adam Nemet via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: anemet
> Date: Mon Mar 28 13:29:36 2016
> New Revision: 264612
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=264612&view=rev <http://llvm.org/viewvc/llvm-project?rev=264612&view=rev>
> Log:
> [PGO] Comment how function pointers for indirect calls are mapped to function names
> 
> Summary:
> Hopefully this will make it easier for the next person to figure all
> this out...
> 
> Reviewers: bogner, davidxl
> 
> Subscribers: llvm-commits
> 
> Differential Revision: http://reviews.llvm.org/D18490 <http://reviews.llvm.org/D18490>
> 
> Modified:
>     compiler-rt/trunk/lib/profile/InstrProfData.inc
> 
> Modified: compiler-rt/trunk/lib/profile/InstrProfData.inc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfData.inc?rev=264612&r1=264611&r2=264612&view=diff <http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfData.inc?rev=264612&r1=264611&r2=264612&view=diff>
> ==============================================================================
> --- compiler-rt/trunk/lib/profile/InstrProfData.inc (original)
> +++ compiler-rt/trunk/lib/profile/InstrProfData.inc Mon Mar 28 13:29:36 2016
> @@ -73,6 +73,8 @@ INSTR_PROF_DATA(const uint64_t, llvm::Ty
>  INSTR_PROF_DATA(const IntPtrT, llvm::Type::getInt64PtrTy(Ctx), CounterPtr, \
>                  ConstantExpr::getBitCast(CounterPtr, \
>                  llvm::Type::getInt64PtrTy(Ctx)))
> +// This is used to map function pointers for the indirect call targets to
> +// function name hashes during the conversion from raw to merged profile data.
>  INSTR_PROF_DATA(const IntPtrT, llvm::Type::getInt8PtrTy(Ctx), FunctionPointer, \
>                  FunctionAddr)
>  INSTR_PROF_DATA(IntPtrT, llvm::Type::getInt8PtrTy(Ctx), Values, \
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160328/b53f3463/attachment.html>


More information about the llvm-commits mailing list