[PATCH] D18468: Profile summary cleanup.

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 10:51:55 PDT 2016


On Mon, Mar 28, 2016 at 1:50 PM, Easwaran Raman <eraman at google.com> wrote:

> danielcdh wrote:
>> dnovillo wrote:
>> > Perhaps we should deprecate getMaxHeadSamples?  IIUC, MaxFunctionCount is the number of times a function was called, correct?  That's essentially the same information provided by counting the number of samples in the function header.
>> >
>> > There is a difference between the two, but I don't think the distinction is worth keeping.  Dehao, what do you think?
>> Agree, MaxHeadSamples should be the same as MaxFunctionCount.
> I thought it is useful in terms of readability to have interfaces named in SampleProfile specific terms. Both MaxHeadSamples and MaxFunctionCount are indeed same and hence getMaxHeadSamples returns the MaxFunctionCount. If this is causing confusion, I'll deprecate this in a separate change.

Sounds good.  Thanks!


More information about the llvm-commits mailing list