[PATCH] D18463: Sparc: silently ignore .proc assembler directive

Douglas Katzman via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 07:05:37 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL264579: Sparc: silently ignore .proc assembler directive (authored by dougk).

Changed prior to commit:
  http://reviews.llvm.org/D18463?vs=51609&id=51786#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D18463

Files:
  llvm/trunk/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
  llvm/trunk/test/MC/Sparc/sparc-directives.s

Index: llvm/trunk/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
===================================================================
--- llvm/trunk/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
+++ llvm/trunk/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
@@ -684,6 +684,12 @@
     Parser.eatToEndOfStatement();
     return false;
   }
+  if (IDVal == ".proc") {
+    // For compatibility, ignore this directive.
+    // (It's supposed to be an "optimization" in the Sun assembler)
+    Parser.eatToEndOfStatement();
+    return false;
+  }
 
   // Let the MC layer to handle other directives.
   return true;
Index: llvm/trunk/test/MC/Sparc/sparc-directives.s
===================================================================
--- llvm/trunk/test/MC/Sparc/sparc-directives.s
+++ llvm/trunk/test/MC/Sparc/sparc-directives.s
@@ -1,6 +1,10 @@
 ! RUN: llvm-mc %s -arch=sparc   -show-encoding | FileCheck %s --check-prefix=SPARC32
 ! RUN: llvm-mc %s -arch=sparcv9 -show-encoding | FileCheck %s --check-prefix=SPARC64
 
+        ! '.proc' is documented to do nothing in the binutils assembler.
+        ! so it should do nothing for clang either, i.e. not be an error.
+        .proc 1
+
         ! SPARC32: .byte 24
         ! SPARC64: .byte 24
         .byte 24


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18463.51786.patch
Type: text/x-patch
Size: 1258 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160328/17fad6df/attachment.bin>


More information about the llvm-commits mailing list