[PATCH] D18190: [ELF] - Error out when R_X86_64_PC32/R_X86_64_32 are used against preemptible symbol when linking shared object.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Target.cpp:739
@@ +738,3 @@
+    if (Config->Shared)
+      error("relocation " + getELFRelocationTypeName(EM_X86_64, Type) +
+            " cannot be used when making a shared object; "
----------------
rafael wrote:
> I am not a very big fan of the wording.
> 
> The relocation *can* be used when making a shared object, it just has to resolve.
> 
> We could say something like "cannot be used in a dynamic relocation", but not sure if that is more useful.
We probably can change this to gold version: "requires dynamic R_X86_64_32 reloc which may overflow at runtime; recompile with -fPIC".
At least that is consistent.


http://reviews.llvm.org/D18190