[PATCH] D18419: Handle section vs global name conflict.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 05:14:07 PDT 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: test/MC/ELF/section-sym-redefine.s:23
@@ +22,3 @@
+.globl x4
+x4:
+.long 0
----------------
Just to make it more complete, can you put symbol x4 in a section other than x4? Just adding

.section foo, "a", @progbits

before

x4:

should do it.

Also, please test a case where a symbol conflict with an implicit section. Name a symbol .text for example.


Repository:
  rL LLVM

http://reviews.llvm.org/D18419





More information about the llvm-commits mailing list