[PATCH] D18343: ThinLTO: use the callgraph from the combined index to drive the FunctionImporter

[Teresa Johnson via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM, just a couple nits below. Thanks!


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:122
@@ +121,3 @@
+        assert(Summary && "Unexpected GlobalValueInfo without summary");
+        if (Summary->modulePath() == ExportModulePath) {
+          return true;
----------------
Nit: unneeded braces

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:176
@@ +175,3 @@
+    ExportList.insert(GUID);
+    // Insert every functions and globals referenced by this function in the
+    // source module as exported from outside as well.
----------------
Maybe "Mark all functions and globals referenced by this function as exported to the outside if they are defined in the same source module."?


http://reviews.llvm.org/D18343