[PATCH] D18438: Calculate __builtin_object_size when pointer depends on a condition

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 11:17:26 PDT 2016

george.burgess.iv added a comment.

> I was thinking to resolve handling Phis and including offset in calculating min and max values (for select and for phi) in next patch if it is OK with you.

Sorry, "next patch" meaning the next revision to this review, or a different patch after this is committed?

If the former: sounds good!

If the latter: I'm fine if you want to commit Phi handling separately, but the offset issue seems like it would introduce a bug that breaks existing, correct code. I don't think that would be good. :)

Comment at: include/llvm/Analysis/MemoryBuiltins.h:139
@@ -133,1 +138,3 @@
+/// If Mode is Min or Max the size will be evaluated even if it depends on
+/// a condition and correspondig value will be returned (min or max).
 bool getObjectSize(const Value *Ptr, uint64_t &Size, const DataLayout &DL,
Typo: "correspondig"



More information about the llvm-commits mailing list