[PATCH] D18281: [SetVector] Add erase() method

[David Blaikie via llvm-commits]

On Fri, Mar 25, 2016 at 11:05 AM, Daniel Berlin via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Does it have the range definition?
>

Looks like the range definition has the same bug/fix?


> (and what is our minimum version required at this point?)
>

According to (
http://llvm.org/docs/CodingStandards.html#supported-c-11-language-and-library-features
) we're still supporting GCC 4.7 and this seems to have been fixed only in
GCC/libstdc++ 4.9 based on my crude experiments.

- Dave


>
> On Fri, Mar 25, 2016 at 10:38 AM, Jun Bum Lim <junbuml at codeaurora.org>
> wrote:
>
>> junbuml added a comment.
>>
>> > /usr/include/c++/4.8/bits/vector.tcc:134:5: note: std::vector<_Tp,
>> _Alloc>::iterator std::vector<_Tp, _Alloc>::erase(std::vector<_Tp,
>> _Alloc>::iterator) [with _Tp = int; _Alloc = std::allocator<int>;
>> std::vector<_Tp, _Alloc>::iterator = __gnu_cxx::__normal_iterator<int*,
>> std::vector<int> >; typename std::_Vector_base<_Tp, _Alloc>::pointer = int*]
>>
>>
>> From the Buildbot log above c++4.8 seems to be used which do not have
>> c++11's definition of vector.erase(). Let me get the a non-const iterator
>> as Danny mentioned.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> http://reviews.llvm.org/D18281
>>
>>
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160325/8aff322d/attachment.html>