[PATCH] D18343: ThinLTO: use the callgraph from the combined index to drive the FunctionImporter

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 10:44:37 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:95
@@ +94,3 @@
+/// null if there's no match.
+static const FunctionSummary *selectCallee(uint64_t GUID, unsigned Threshold,
+                                           const ModuleSummaryIndex &Index) {
----------------
davidxl wrote:
> Why not passing a reference of the Edge to 'selectCallee'. We will need to look at profile data in the future.
I think the profile info will not impact *which* callee you select right? What do you expect to do with this information at this level?


http://reviews.llvm.org/D18343





More information about the llvm-commits mailing list