[llvm] r264420 - Revert "[SetVector] Add erase() method"

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 09:49:17 PDT 2016


Author: junbuml
Date: Fri Mar 25 11:49:16 2016
New Revision: 264420

URL: http://llvm.org/viewvc/llvm-project?rev=264420&view=rev
Log:
Revert "[SetVector] Add erase() method"

This reverts commit r264414.

Removed:
    llvm/trunk/unittests/ADT/SetVectorTest.cpp
Modified:
    llvm/trunk/include/llvm/ADT/SetVector.h
    llvm/trunk/unittests/ADT/CMakeLists.txt

Modified: llvm/trunk/include/llvm/ADT/SetVector.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/SetVector.h?rev=264420&r1=264419&r2=264420&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ADT/SetVector.h (original)
+++ llvm/trunk/include/llvm/ADT/SetVector.h Fri Mar 25 11:49:16 2016
@@ -151,17 +151,6 @@ public:
     return false;
   }
 
-  /// Erase a single element from the set vector.
-  /// \returns an iterator pointing to the next element that followed the
-  /// element erased. This is the end of the SetVector if the last element is
-  /// erased.
-  iterator erase(iterator I) {
-    const key_type &V = *I;
-    assert(set_.count(V) && "Corrupted SetVector instances!");
-    set_.erase(V);
-    return vector_.erase(I);
-  }
-
   /// \brief Remove items from the set vector based on a predicate function.
   ///
   /// This is intended to be equivalent to the following code, if we could

Modified: llvm/trunk/unittests/ADT/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/CMakeLists.txt?rev=264420&r1=264419&r2=264420&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/CMakeLists.txt (original)
+++ llvm/trunk/unittests/ADT/CMakeLists.txt Fri Mar 25 11:49:16 2016
@@ -32,7 +32,6 @@ set(ADTSources
   PostOrderIteratorTest.cpp
   RangeAdapterTest.cpp
   SCCIteratorTest.cpp
-  SetVectorTest.cpp
   SmallPtrSetTest.cpp
   SmallStringTest.cpp
   SmallVectorTest.cpp

Removed: llvm/trunk/unittests/ADT/SetVectorTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/SetVectorTest.cpp?rev=264419&view=auto
==============================================================================
--- llvm/trunk/unittests/ADT/SetVectorTest.cpp (original)
+++ llvm/trunk/unittests/ADT/SetVectorTest.cpp (removed)
@@ -1,34 +0,0 @@
-//===- llvm/unittest/ADT/SetVector.cpp ------------------------------===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-//
-// SetVector unit tests.
-//
-//===----------------------------------------------------------------------===//
-
-#include "llvm/ADT/SetVector.h"
-#include "gtest/gtest.h"
-
-using namespace llvm;
-
-TEST(SetVector, EraseTest) {
-  SetVector<int> S;
-  S.insert(0);
-  S.insert(1);
-  S.insert(2);
-
-  auto I = S.erase(std::next(S.begin()));
-
-  // Test that the returned iterator is the expected one-after-erase
-  // and the size/contents is the expected sequence {0, 2}.
-  EXPECT_EQ(std::next(S.begin()), I);
-  EXPECT_EQ(2u, S.size());
-  EXPECT_EQ(0, *S.begin());
-  EXPECT_EQ(2, *std::next(S.begin()));
-}
-




More information about the llvm-commits mailing list