[PATCH] D18330: [ELF/AArch64] Implemented set of R_AARCH64_TLSDESC_* relocations.

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 07:01:02 PDT 2016

zatrazz added inline comments.

Comment at: ELF/OutputSections.cpp:80
@@ -69,1 +79,3 @@
+template <class ELFT> size_t GotPltSection<ELFT>::getTailIndex(uint32_t I) {
+  return Target->GotPltHeaderEntriesNum + Entries.size() - Tail + I;
rafael wrote:
> Can you provide a description of what this is?
> In general, any reason you cannot just use  GlobalDynIndex for the position of the pair of got entries you need?
The 'Tail' basically keep the position of last default relocation since tlsdesc for aarch64 are place after the jump slots and IRELATIVE. 

And I think we can GlobalDynIndex instead of using this extra function. I will check that.



More information about the llvm-commits mailing list