[PATCH] D18465: [sanitizer] Add memset, memmove, and memcpy to the common interceptors

Derek Bruening via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 18:20:59 PDT 2016

bruening marked an inline comment as done.

Comment at: lib/tsan/rtl/tsan_interceptors.cc:673
@@ -672,3 @@
-  // On FreeBSD we get here from libthr internals on thread initialization.
-    SCOPED_TSAN_INTERCEPTOR(memset, dst, v, size);
eugenis wrote:
> Looks like you've lost COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED check in the common interceptor.
Good catch.  The asan and msan COMMON_INTERCEPTOR_ENTER do their own is-initialized checks in general (though calling REAL instead of internal_) and samsonov was in favor of relying on those for earlier common interceptors.  The tsan _ENTER does not do any check.  IMHO these explicit is-init checks should remain here, as the REAL will not work prior to init, rather than just adding a REAL call if !init to tsan's _ENTER.


More information about the llvm-commits mailing list