[PATCH] D18246: X86: Use push-pop for materializing 8-bit immediates for minsize (take 2)

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 18:09:55 PDT 2016

hans marked an inline comment as done.

Comment at: lib/Target/X86/X86InstrCompiler.td:286
@@ +285,3 @@
+                       [(set GR32:$dst, i32immSExt8:$src)]>,
+                     Requires<[OptForMinSize]>;
+def MOV64ImmSExti8 : I<0, Pseudo, (outs GR64:$dst), (ins i64i8imm:$src), "",
majnemer wrote:
> Why isn't this `NotWin64WithoutFP` ?
Looks like I forgot to add it. I'll fix this and add a test when committing.


More information about the llvm-commits mailing list