[PATCH] D17859: [InstCombine] convert 'isPositive' and 'isNegative' vector comparisons to shifts (PR26701, PR26819)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 18:03:26 PDT 2016

On Thu, Mar 24, 2016 at 6:31 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:

> My question was rather "if the canonicalization would be done on vector,
> would you have to handle all the variant of the comparison operators?"

Ah, I understand now. The answer would be 'no'. If we do the comparison
canonicalization, we wouldn't have to change this InstCombineCasts function
at all.

I actually did start on that path to extend the existing comparison
canonicalization, but then I wondered why vectors were excluded. Then, I
saw that it would probably be a bigger patch, and I would have no idea if
it would harm other targets, so I opted for this patch instead. :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160324/ab41b5db/attachment.html>

More information about the llvm-commits mailing list