[llvm] r264341 - [Support] Add ErrorInfo::ID static member definition.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 17:14:33 PDT 2016

Hi All,

Alexey, Takumi: Sorry, I missed that fix. Evidently I need to expand my
commit filters.

I think you can solve the problem the same way I suggested that Chandler do
> it: make the derived error classes responsible for providing this symbol,
> and have classID() return &ThisErrT::ID.

Yep - this is the best way to fix this. I'll make the changes.


On Thu, Mar 24, 2016 at 4:33 PM, Reid Kleckner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Thu, Mar 24, 2016 at 4:31 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> Pretty unfortunate additional boilerplate (perhaps moreso in the pass
>> manager than in the error categories, not sure which we'll end up with more
>> of in the long run), but if that's the nearest we can do...
> Sure, but it's normal, character-building, C++ boilerplate. We still
> prototype our methods in header files like cavemen, rather than making
> every function inline.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160324/89a3bef5/attachment.html>

More information about the llvm-commits mailing list