[PATCH] Correct misspelled "XDS" to "XDG" in Support/Unix/Path.inc
Robert Ma via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 24 16:15:35 PDT 2016
Thank you Sean and Paweł for helping to commit and the advise on the
process! Yeah I guess explicitly asking for help on committing is
easier to understand and makes others realize immediately that I don't
have write access.
Paweł mentioned about Phabricator, which makes me want to bring up my
feeling when reading the Developer Policy
Personally I was a bit confused about what to do as someone outside
the project writing a quick fix. The document first says the commit
list is "preferred" and later describes Phabricator as "optionally
used". I was even tempted to both send the patch to llvm-commits
manually AND create a review on Phabricator, but found out that was
not right only after reading another document
(http://llvm.org/docs/Phabricator.html). It might be good to
streamline the recommended process for "one-off" patches and clarify
the commit list v.s. Phabricator a bit more.
Lastly, about the unit tests Paweł mentioned, I checked both the
original commit (r251784) and the latest svn trunk. The related test
is mainly for path concatenation and Unicode handling. The name of the
environment variable is not tested, so I believe neither the typo nor
the fix for the typo would affect the test.
Again, much appreciate your help!
2016-03-24 15:34 GMT-07:00 Paweł Bylica <chfast at gmail.com>:
> Sorry for late response, but I'm not actively monitoring LLVM commits any
> Yes, this is a typo and should be fixed.
> There should also be unit tests that need to be checked and corrected.
> The very preferred way of sending patches is to put then on LLVM review
> board http://reviews.llvm.org.
> The procedure is described in documentation
> In the end, if you don't have write access to SVN, you will need to ask
> somebody to commit your patch.
> On Thu, Mar 24, 2016 at 10:53 PM Robert Ma via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Hello LLVM community,
>> Sorry for bumping this thread again, but it's been quite a while and
>> there is no response other than Sean's. I've also tried asking for
>> help on #llvm IRC, but didn't get answers either. How should I push
>> this forward?
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
Robert Ma (Hexcles)
More information about the llvm-commits