[PATCH] D18419: Handle section vs global name conflict.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.

================
Comment at: lib/MC/ELFObjectWriter.cpp:390
@@ +389,3 @@
+
+    Renames.insert(
+        std::make_pair(cast<MCSymbolELF>(Alias), cast<MCSymbolELF>(Begin)));
----------------
pcc wrote:
> eugenis wrote:
> > pcc wrote:
> > > This problem affects the other object formats as well. Can't you do this in the generic object format lowering code with `setVariableValue`?
> > In that case we emit two symbols instead of one. Also, the MCContext part is ELF specific, too.
> > In that case we emit two symbols instead of one. 
> 
> You could set `IsTemporary` on the symbol you look up.
> 
> > Also, the MCContext part is ELF specific, too.
> 
> Sorry, I don't see how that is the case.
Okay, feel free to disregard all this. This does seem to be ELF-specific.


Repository:
  rL LLVM

http://reviews.llvm.org/D18419