[PATCH] D17736: [SSP, 1/2] Refactor to support customizable stack guard load from IR level.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 14:42:02 PDT 2016


echristo added a comment.

Starting to look better, needs autoupgrade support and tests. I'm uncertain about putting one aspect of the set of intrinsics into experimental since the other two aren't already, but it's a simple change once we get the rest of it.

Can you add to the patch description a lot of the comments in the review? Also talk about the change of useLoadStackGuardNode to forceLoadStackGuardNode, etc.

Thanks!

-eric


http://reviews.llvm.org/D17736





More information about the llvm-commits mailing list