[PATCH] D18419: Handle section vs global name conflict.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 13:55:09 PDT 2016


eugenis added inline comments.

================
Comment at: lib/MC/ELFObjectWriter.cpp:390
@@ +389,3 @@
+
+    Renames.insert(
+        std::make_pair(cast<MCSymbolELF>(Alias), cast<MCSymbolELF>(Begin)));
----------------
pcc wrote:
> This problem affects the other object formats as well. Can't you do this in the generic object format lowering code with `setVariableValue`?
In that case we emit two symbols instead of one. Also, the MCContext part is ELF specific, too.


Repository:
  rL LLVM

http://reviews.llvm.org/D18419





More information about the llvm-commits mailing list