[PATCH] D18419: Handle section vs global name conflict.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 13:32:18 PDT 2016

eugenis added inline comments.

Comment at: include/llvm/MC/MCContext.h:101
@@ -100,2 +100,3 @@
     StringMap<bool, BumpPtrAllocator &> UsedNames;
+    StringMap<bool, BumpPtrAllocator &> UsedSectionNames;
pcc wrote:
> I don't think you need to add this field. You could just use `UsedNames` for section names and use the bool value to keep track of whether the symbol name has been used for a non-section. The bool appears to be unused at the moment [1].
> [1] http://llvm-cs.pcc.me.uk/include/llvm/MC/MCSymbol.h/rgetNameEntryPtr http://llvm-cs.pcc.me.uk/include/llvm/MC/MCSymbol.h/rgetNameEntryPtr-1
Good point, done.



More information about the llvm-commits mailing list